poorejc commented on a change in pull request #234:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/234#discussion_r834944555
##########
File path: src/main.js
##########
@@ -63,7 +63,7 @@ function setup(config) {
setTimeout(function () {
const state = document.readyState;
- if (state === 'interactive' || state === 'complete') {
+ if (config.autostart && (state === 'interactive' || state ===
'complete')) {
Review comment:
I'm seeing desired behavior for 'autostart: false'. However, this may be
way userale.start() is not working. If 'atutostart':false' and 'setup' checks
for autostart === true, then if 'autostart:false', then I'm not sure how to
turn userale on...
seems that ln 66 is doing all the work here. regressing it, I'm seeing logs
when 'autostart':false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
