kevbrowndev commented on pull request #234: URL: https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1079013292
I'll take a look at your branch tonight. Thanks! On Fri, Mar 25, 2022, 2:55 AM poorejc ***@***.***> wrote: > Good point.... So we want start to work even if autostart is set to > false... What if we set autostart to true with function start()? That might > not work because the configure() function now ensures that autostart will > be false if either config has an autostart equaling false. Back to the > drawing board! Earlier I was thinking we might need another variable in > options. Perhaps one called hardstop that we don't advertise. We can set > that in start and stop methods to true or false as the case may be... And > check it in setup. What do you think? It might be worth testing but I can't > do anything more tonight. > … <#m_-302143585622002367_> > On Fri, Mar 25, 2022, 12:29 AM poorejc *@*.*> wrote: @.** commented on > this pull request. ------------------------------ In src/main.js <#234 > (comment) > <https://github.com/apache/incubator-flagon-useralejs/pull/234#discussion_r834944555>> > : > @@ -63,7 +63,7 @@ function setup(config) { setTimeout(function () { > const state = document.readyState; - if (state === 'interactive' || state > === 'complete') { + if (config.autostart && (state === 'interactive' || > state === 'complete')) { I'm seeing desired behavior for 'autostart: > false'. However, this may be way userale.start() is not working. If > 'atutostart':false' and 'setup' checks for autostart === true, then if > 'autostart:false', then I'm not sure how to turn userale on... — Reply to > this email directly, view it on GitHub <#234 (review) > <https://github.com/apache/incubator-flagon-useralejs/pull/234#pullrequestreview-921164788>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AAOZLZ4GJKBKITGMZ5MD573VBU6LDANCNFSM5RPXDKAQ > . You are receiving this because you commented.Message ID: *@*.***> > > didn't see your comment earlier--Im seeing desired behavior for toggling > autostart on through Start(), but doing it directly through > config.autostart not userale.options. First page load, I miss a few events > (incl pageload), but on refresh, I see the pageload event... We'll beat on > it some more. Hopefully, this sticks. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1078713847>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAOZLZ3OVGYJTG32PHIVTX3VBVPNRANCNFSM5RPXDKAQ> > . > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
