kevbrowndev commented on pull request #234: URL: https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1081335857
Sounds good to me! Thank you. On Mon, Mar 28, 2022, 9:56 PM UncleGedd ***@***.***> wrote: > @kevbrowndev <https://github.com/kevbrowndev> thanks for all your help > with this, I think you've made a really nice solution. I made a couple of > small edits to the tests and in the React example to showcase/test the > expected start/stop behavior. Everything looks great on my end, but please > feel free to test more. > > If you are okay with it, I'd like to push the > autostart-honored-in-options-function branch from your fork to this repo, > squash the commits and get it merged in. > > Next step is to finish up #88 > <https://github.com/apache/incubator-flagon-useralejs/issues/88> and add > some journey tests to really dig into this functionality that you've > added/fixed! > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1081318769>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAOZLZ7N6KC3IF6P7Z5ULP3VCJPL5ANCNFSM5RPXDKAQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
