[GitHub] [incubator-flagon-useralejs] kevbrowndev commented on pull request #234: WIP: Allow those using Userale as NPM package to set autostart to false and thereby stop Userale logging

[GitBox]

kevbrowndev commented on pull request #234:
URL: 
https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1081230519


   Thanks!
   
   I made a slight change to the `start` function that seems to solve the 
problem and merged it into the `autostart-honored-in-options-function` branch:
   
   ```
   /**
    * Used to start the logging process if the
    * autostart configuration option is set to false.
    */
   export function start() {
       if (!started || config.autostart === false) {
           started = config.on = true;
           config.autostart = true;
       }
   }
   
   ```
   
   What do you think?  I'ed like to do a little more testing and maybe try to 
write an automated test or two


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org