Sound good. I have not tried building custom hbase against hadoop2. But i assume this has been tried out ? in which case +1 from me.
-roshan On Mon, May 12, 2014 at 11:19 PM, Hari Shreedharan < [email protected]> wrote: > The original email probably went missing due to the ASF email issue. > > As far as the Hbase sink/asynchbase issue, did you build hbase .94.2 > against Hadoop 2? Hbase did not realize artifacts built against Hadoop 2 > before hbase .96. If you don't have hbase 94 built against Hadoop 2, mvn > will pull the one available on central which is built against Hadoop 1. > > I don't think we need to build a new RC for the doc bug. I can deploy the > patches docs on the website without doing another RC. > > Also, the copyright year is not a blocker - we have released 3 times after > 2012. > > Hari > > On Monday, May 12, 2014, Roshan Naik <[email protected]> wrote: > > > Sidenote: For some reason I didnt receive Hari's original email > announcing > > RC1. > > > > > > > > Anyway here are my observations: > > > > - verified checksums (src & bin) - Looks good > > - verified builds works ok for regular build and also > > with -Dhadoop.profile=2 option - Looks good > > > > Unit Tests: > > - Manually brought up a sample Flume agent using the binary dist - Looks > > good > > - Ran a few unit tests (SpillChannel onwards) for hadoop1 profile. - > Looks > > good. > > - Ran unit tests for hadoop2 profile - *Failures in TestAsyncHBaseSink & > > TestHBaseSink*. Rest ok. See details below. > > > > - Documentation: - *Noticed a few issues*. > > + The date in the COPYRIGHT file is 2012 .. does this need to be > 2014 ? > > + README file : Wonder if we should we also mention the > > '-Dhadoop.profile=2' altnerative option for building the distro here ? > > + Spillable Channel has a documentation bug in the last example. It > > omits setting one of the variables that is essential for that example. > > Fault is mine. Apologies. If we agree to fix this.. Let me know i can > > provide a patch (its trivial) just need to add > > "a1.channels.c1.overflowCapacity > > = 0" in this last example. > > > > -roshan > > > > > > *Test Failures Details:* > > > mvn -Dhadoop.profile=2 test > > > > *Running org.apache.flume.sink.hbase.TestAsyncHBaseSink* > > > > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.472 sec > > <<< FAILURE! > > org.apache.flume.sink.hbase.TestAsyncHBaseSink Time elapsed: 471 sec > <<< > > ERROR! > > java.lang.NoSuchMethodError: > > > > > org.apache.hadoop.hdfs.MiniDFSCluster.<init>(ILorg/apache/hadoop/conf/Configuration;IZZZLorg/apache/hadoop/hdfs/server/common/HdfsConstants$StartupOption;[Ljava/lang/String;[Ljava/lang/String;[J)V > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:433) > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:601) > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:557) > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:526) > > at > > > > > org.apache.flume.sink.hbase.TestAsyncHBaseSink.setUp(TestAsyncHBaseSink.java:69) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:597) > > at > > > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > > at > > > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > > at > > > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > > at > > > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) > > at > > > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > > at > > > > > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) > > at > > > > > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) > > at > > > > > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:597) > > at > > > > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) > > at > > > > > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) > > at > > > > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) > > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) > > > > *Running org.apache.flume.sink.hbase.TestHBaseSink* > > > > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.465 sec > > <<< FAILURE! > > org.apache.flume.sink.hbase.TestHBaseSink Time elapsed: 464 sec <<< > > ERROR! > > java.lang.NoSuchMethodError: > > > > > org.apache.hadoop.hdfs.MiniDFSCluster.<init>(ILorg/apache/hadoop/conf/Configuration;IZZZLorg/apache/hadoop/hdfs/server/common/HdfsConstants$StartupOption;[Ljava/lang/String;[Ljava/lang/String;[J)V > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:433) > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:601) > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:557) > > at > > > > > org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:526) > > at > > > org.apache.flume.sink.hbase.TestHBaseSink.setUpOnce(TestHBaseSink.java:81) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:597) > > at > > > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > > at > > > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > > at > > > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > > at > > > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) > > at > > > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > > at > > > > > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) > > at > > > > > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) > > at > > > > > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:597) > > at > > > > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) > > at > > > > > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) > > at > > > > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) > > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) > > > > Running org.apache.flume.sink.hbase.TestHBaseSinkCreation > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.274 sec > > Running org.apache.flume.sink.hbase.TestRegexHbaseEventSerializer > > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.306 sec > > > > > > > > > > > > > > > > > > -- > > CONFIDENTIALITY NOTICE > > NOTICE: This message is intended for the use of the individual or entity > to > > which it is addressed and may contain information that is confidential, > > privileged and exempt from disclosure under applicable law. If the reader > > of this message is not the intended recipient, you are hereby notified > that > > any printing, copying, dissemination, distribution, disclosure or > > forwarding of this communication is strictly prohibited. If you have > > received this communication in error, please contact the sender > immediately > > and delete it from your system. Thank You. > > > -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
