-1 for RC1
I've found a few problems with RC1:
1. As mentioned by Donat, the signed source artifact was corrupted somehow,
I am guessing the maven assembly plugin had some problem at build / deploy
time
2. I locally built a source tarball from the RC1 tag and compared the file
contents with the git tag. I noticed the following discrepancies in the
resulting source artifact:
* README.md is missing from the source tarball
* doap_Flume.rdf is missing from the source tarball
* The source tarball contains .iml files from my local dev environment
3. I checked that the binary artifact starts up with a simple configuration
file. I checked the LICENSE file and found the discrepancies that Attila
found as well.
Personally I don't like using the maven-assembly-plugin to generate the
source artifact, since it requires maintenance. IMHO it would be better to
replace it with a small shell script that invoked git archive against the
release tag, but that is not a release blocker.
Mike
On Wed, Oct 12, 2016 at 5:07 PM, Attila Simon <s...@cloudera.com> wrote:
> Hi All,
>
> I checked the shipped libraries against the LICENSE file in the binary
> tarball. It turned out that there are some discrepancies.
>
> Additional libraries shipped but not mentioned in the licence file:
> hamcrest-core (BSD License), junit (BSD License), xz
> (http://git.tukaani.org/?p=xz.git;a=blob;f=COPYING),
> kafka-clients(Apache License v2),
> lz4(https://github.com/lz4/lz4/blob/master/lib/LICENSE)
>
> Library mentioned in the licence file but not shipped directly:
> zookeeper(Apache License v2)
>
> Libraries which require little correction in the name in the licence file:
> jackson-core-asl-1.<version>.jar
> jackson-mapper-asl-1.<version>.jar
>
> Suggested actions:
> 1) hamcrest-core, junit these are testing libs, I think shouldn't be
> shipped (only required for tests, I guess they were added by the new
> .*shared.* module)
> 2) kafka-clients, lz4 should be added to our LICENSE file
> 3) jackson.* fix the typo in the LICENSE file
> 4) zookeeper since we depend on zkclient instead we should remove
> this from the LICENSE file.
>
> Cheers,
> Attila
>
>
>
> On Tue, Oct 11, 2016 at 7:23 PM, Balazs Donat Bessenyei
> <bes...@cloudera.com> wrote:
> >
> > Hi All,
> >
> > This is the tenth release for Apache Flume as a top-level project,
> > version 1.7.0. We are voting on release candidate RC1.
> >
> > It fixes the following issues:
> > https://raw.githubusercontent.com/apache/flume/flume-1.7/CHANGELOG
> >
> > *** Please cast your vote within the next 72 hours ***
> >
> > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1)
> > for the source and binary artifacts can be found here:
> > http://people.apache.org/~bessbd/apache-flume-1.7.0-rc1/
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/
> orgapacheflume-1018/
> >
> > The tag to be voted on:
> > https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=1a62453
> >
> > Flume's KEYS file containing PGP keys we use to sign the release:
> > https://www.apache.org/dist/flume/KEYS
> >
> >
> > Thank you,
> >
> > Donat
>
