Thanks Sergio! I wasn't able to review this release, but I'll be reviewing the next one.
On Tuesday, January 19, 2016, Sergio Fernández <[email protected]> wrote: > Another remark for the future: all other non-binding votes from committers > are usually quite appreciated by the IPMC to validate the process. Also the > Release Manager (in this release Daniel) could also vote. > > Step by step, guys, you're doing a good job. Sorry if sometimes I could be > a bit picky, but I'm just trying to help you learning the processes. > > On Tue, Jan 19, 2016 at 11:00 PM, Daniel Dekany <[email protected] > <javascript:;>> wrote: > > > The vote passes with 3, +1 binding votes, and one -1 binding votes > > from the PPMC members: > > > > David E Jones +1 (binding) > > Jacopo Cappellato +1 (binding) > > Ralph Goers +1 (binding) > > Sergio Fernández -1 (binding) > > > > As of the -1, see the discussion quoted below, and note that Sergio > > Fernández has informally agreed to continue on [email protected]. > > > > Thanks for voting, we will proceed with voting on > > [email protected]! > > > > -- > > Thanks, > > Daniel Dekany > > > > > > Tuesday, January 19, 2016, 8:41:44 PM, Sergio Fernández wrote: > > > > > Hi, > > > > > > On Jan 19, 2016 20:05, "Daniel Dekany" <[email protected] > <javascript:;>> wrote: > > >> > > >> You mean, it should have been version 2.3.24-rc01-a3 (in Maven and > > >> everywhere), or just the non-Maven download URL-s should use separate > > >> URL-s? > > > > > > No, only for the source release, which is what we actually vote in ASF. > > > Just naming the source folder with such convention would prevent the > > > confusion we had. For next releases, please take that into account as > > well > > > as the importance of canceling vote threads properly. > > > > > >> Anyway, I won't make a problem out of formalities like this, so > > >> whatever the ASF conventions says. For now though, can we just proceed > > >> on incubator@general? Yes, formally we could (Majority Approval), but > > >> given that you seem to spot policy issues efficiently, I'm curious if > > >> you have checked the content of the artifacts. Or if you plan to do > > >> that, because then I would wait for that. > > > > > > Yes, go ahead there, please. I didn't find time to check this last > > attempt, > > > but I'll do it while the vote runs at [email protected] > > > > > > Thanks. > > > > > >> Tuesday, January 19, 2016, 8:38:52 AM, Sergio Fernández wrote: > > >> > > >> > Hi Daniel, > > >> > > > >> > my issue with such workflow is that behind the assertion that "All > the > > >> > links remain as they were" there is a potential mismatch between the > > > latest > > >> > release and the downloaded one, as Jacopo pointed with the hashes. > > >> > > > >> > Specific release source must be linked in the vote email. Normally > > ASF > > >> > projects use RC workflows for such internal links, having a way to > > >> > differentiate between each try. As we discussed, Freemarker will > > publish > > >> > those RCs. Therefore my recommendation would be to specifically name > > > each > > >> > release with the attempt number to avoid such issue. Would that work > > for > > >> > you? > > >> > > > >> > Of course I could vote the current release; but I'm just trying to > > show > > > the > > >> > project the procedures you should follow. Hope you understand my > > point. > > >> > > > >> > Cheers, > > >> > > > >> > > > >> > On Mon, Jan 18, 2016 at 9:53 PM, Daniel Dekany <[email protected] > <javascript:;>> > > > wrote: > > >> > > > >> >> It's iteration over the same public release (2.3.24-rc01), before > > >> >> sending it to voting on general@incubator. There are no downloads > > for > > >> >> the attempts except for the last. ("All the links remain as they > > >> >> were.", as the mail said.) But of course, I will include the links > > >> >> directly in later votes. > > >> >> > > >> >> Have you check the content of the artifacts or do you plan to do > > that? > > >> >> > > >> >> The source artifacts are here ("normal" and GAE, the two branches): > > >> >> > > >> >> > > > > > > https://dist.apache.org/repos/dist/dev/incubator/freemarker/engine/2.3.24-rc01-incubating/source/ > > >> >> > > >> >> > > >> >> -- > > >> >> Thanks, > > >> >> Daniel Dekany > > >> >> > > >> >> > > >> >> Monday, January 18, 2016, 10:23:06 AM, Sergio Fernández wrote: > > >> >> > > >> >> > -1 (binding), source link is missing from the vote email > > >> >> > > > >> >> > Something confusing on the overall release is that normally RC > > >> >> > releases are what here are called attepts, because the project > > >> >> > actually wants to publish RCs; so I guess the attempt number > should > > >> >> > be kept somewhere, folder name or wherever. > > >> >> > > > >> >> > On Mon, Jan 18, 2016 at 8:23 AM, Jacopo Cappellato > > >> >> > <[email protected] <javascript:;>> wrote: > > >> >> > Yes, you are right; I was confused because I have actually tested > > > them > > >> >> when > > >> >> > I have voted +1 to the previous attempt (you have announced the > new > > > vote > > >> >> in > > >> >> > the same time I have casted mine). > > >> >> > > > >> >> > Here is my vote: > > >> >> > > > >> >> > +1 > > >> >> > > > >> >> > Jacopo > > >> >> > > > >> >> > > > >> >> > On Sat, Jan 16, 2016 at 10:20 PM, Daniel Dekany < > > [email protected] <javascript:;>> > > >> >> wrote: > > >> >> > > > >> >> >> Those also look fine to me. The artifacts has the new NOTICE > > files, > > >> >> >> and the the sha1 and md5 checksums are correct. > > >> >> >> > > >> >> >> -- > > >> >> >> Thanks, > > >> >> >> Daniel Dekany > > >> >> >> > > >> >> >> > > >> >> >> Saturday, January 16, 2016, 4:34:54 PM, Jacopo Cappellato wrote: > > >> >> >> > > >> >> >> > I was talking about the files here: > > >> >> >> > > > >> >> >> > > > >> >> >> > > >> >> > > > > > > https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.24-rc01-incubating/ > > >> >> >> > > > >> >> >> > Jacopo > > >> >> >> > > > >> >> >> > On Fri, Jan 15, 2016 at 8:52 PM, Daniel Dekany < > > [email protected] <javascript:;>>> > > >> >> >> wrote: > > >> >> >> > Friday, January 15, 2016, 9:46:31 AM, Jacopo Cappellato wrote: > > >> >> >> > > > >> >> >> >> Hi Daniel, > > >> >> >> >> > > >> >> >> >> the release files and the hashes/signatures seem to be the > same > > > of > > >> >> the > > >> >> >> >> previous attempt. Maybe I am missing something but I was > > > expecting a > > >> >> new > > >> >> >> >> version of them so that we could test the integrity of the > > > bundles. > > >> >> >> > > > >> >> >> > Which one? They seem to me up to date > > >> >> >> > ( > > >> >> >> > > >> >> > > > > > > https://dist.apache.org/repos/dist/dev/incubator/freemarker/engine/2.3.24-rc01-incubating/binaries/apache-freemarker-2.3.24-rc01-incubating-bin.tar.gz.md5 > > >> >> >> , > > >> >> >> > etc.) > > >> >> >> > > > >> >> >> > OTOH I see something funny with the sha512 files. If I check > > them > > > out > > >> >> >> > with SVN, they are fine. But if I download them from the web > > URL, > > > they > > >> >> >> > come down gzip-ed... But I assume this glitch has nothing to > do > > > with > > >> >> >> > the release files. > > >> >> >> > > > >> >> >> >> Regards, > > >> >> >> >> > > >> >> >> >> Jacopo > > >> >> >> >> > > >> >> >> >> > > >> >> >> >> On Thu, Jan 14, 2016 at 1:11 AM, Daniel Dekany < > > [email protected] <javascript:;>>> > > >> >> >> wrote: > > >> >> >> >> > > >> >> >> >>> I did an update. No functionality/stability changes, only > > legal > > > ones > > >> >> >> >>> and some build script change: > > >> >> >> >>> > > >> >> >> >>> - NOTICE file changes: > > >> >> >> >>> - Added missing META-INF/NOTICE to the Maven javadoc > > artifact > > >> >> >> >>> - More precise and readable font-related section in the > > binary > > >> >> >> >>> distribution > > >> >> >> >>> - Customized META-INF/NOTICE in freemkarker.jar, to fit > this > > >> >> >> >>> particular artifact. > > >> >> >> >>> - `ant maven-dist` now selects the appropriate target Maven > > repo > > >> >> >> >>> (snapshot VS staging) based on the version number. > > >> >> >> >>> > > >> >> >> >>> All the links remain as there were. Except, the Git commit > > > hashes > > >> >> >> >>> change to this: > > >> >> >> >>> > > >> >> >> >>> Normal version: > > >> >> >> >>> "2.3" branch commit hash: > > > b9ca91dd5c3b04121f5ddcb9f6194c1e7931ba2c > > >> >> >> >>> > > >> >> >> >>> > > >> >> >> > > >> >> > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker.git;a=commit;h=b9ca91dd5c3b04121f5ddcb9f6194c1e7931ba2c > > >> >> >> >>> > > >> >> >> >>> Google App Engine ("gae") compliant version: > > >> >> >> >>> "2.3-gae" branch commit hash: > > >> >> >> 0c71d8f99323577d9683d924c51d617eb0346d15 > > >> >> >> >>> > > >> >> >> >>> > > >> >> >> > > >> >> > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker.git;a=commit;h=0c71d8f99323577d9683d924c51d617eb0346d15 > > >> >> >> >>> > > >> >> >> >>> Please review and vote! > > >> >> >> >>> > > >> >> >> >>> -- > > >> >> >> >>> Thanks, > > >> >> >> >>> Daniel Dekany > > >> >> >> >>> > > >> >> >> >>> > > >> >> >> >>> Thursday, January 7, 2016, 10:29:32 PM, Daniel Dekany wrote: > > >> >> >> >>> > > >> >> >> >>> > Dear Mentors, and everyone else! > > >> >> >> >>> > > > >> >> >> >>> > Here's the 2nd attempt on 2.3.24-rc01-incubating. Nothing > > has > > >> >> changed > > >> >> >> >>> > that affects FreeMarker's functionality/stability. These > are > > >> >> merely > > >> >> >> >>> > fixes related to licensing files and Apache packaging > > > conventions. > > >> >> >> >>> > > > >> >> >> >>> > As previously, if you can, please test the release with > your > > > own > > >> >> >> >>> > FreeMarker-dependent projects, and in general try to find > > > rough > > >> >> >> edges, > > >> >> >> >>> > tell your insights. The binary with full documentation and > > > change > > >> >> >> log: > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > >> >> >> > > >> >> > > > > > > https://dist.apache.org/repos/dist/dev/incubator/freemarker/engine/2.3.24-rc01-incubating/binaries/apache-freemarker-2.3.24-rc01-incubating-bin.tar.gz > > >> >> >> >>> > > > >> >> >> >>> > Git: > > >> >> >> >>> > > > >> >> >> >>> > Normal version: > > >> >> >> >>> > "2.3" branch commit hash: > > >> >> ce1dc19b3ccfb734af551c2d694a3a3d1039f7fa > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > >> >> >> > > >> >> > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker.git;a=commit;h=ce1dc19b3ccfb734af551c2d694a3a3d1039f7fa > > >> >> >> >>> > > > >> >> >> >>> > Googla App Engine ("gae") compliant version: > > >> >> >> >>> > "2.3-gae" branch commit hash: > > >> >> >> >>> > 6166efe1d02fe89a98c7d87ab26a608e2d560492 > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > >> >> >> > > >> >> > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker.git;a=commit;h=6166efe1d02fe89a98c7d87ab26a608e2d560492 > > >> >> >> >>> > > > >> >> >> >>> > (Tagging will happen if and when it indeed becomes to a > > >> >> release.) > > >> >> >> >>> > > > >> >> >> >>> > Maven (jar, javadoc and source artifacts): > > >> >> >> >>> > > > >> >> >> >>> > Repository: > > >> >> >> >>> > > > > https://repository.apache.org/content/repositories/staging/ > > >> >> >> >>> > > > >> >> >> >>> > Browse (Mentors please check contents): > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > >> >> >> > > >> >> > > > > > > https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.24-rc01-incubating/ > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > >> >> >> > > >> >> > > > > > > https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker-gae/2.3.24-rc01-incubating/ > > >> >> >> >>> > > > >> >> >> >>> > Maven coordiantes: > > >> >> >> >>> > <groupId>org.freemarker</groupId> > > >> >> >> >>> > <artifactId>freemarker</artifactId> > > >> >> >> >>> > <version>2.3.24-rc01-incubating</version> > > >> >> >> >>> > > > >> >> >> >>> > or the same with > > <artifactId>freemarker-gae</artifactId>. > > >> >> >> >>> > > > >> >> >> >>> > The staged dist directory structure: > > >> >> >> >>> > > > >> >> >> >>> > > > https://dist.apache.org/repos/dist/dev/incubator/freemarker/ > > >> >> >> >>> > > > >> >> >> >>> > Notes: > > >> >> >> >>> > > > >> >> >> >>> > - See the README for the build instructions. > > >> >> >> >>> > > > >> >> >> >>> > - You can run `ant rat`. If you extract the two > > distributions > > > (I > > >> >> mean > > >> >> >> >>> > the binary and source archives) under build/dist/bin and > > >> >> >> >>> > build/dist/src, it will also check those. (Or if you ran > > > `ant > > >> >> dist` > > >> >> >> >>> > earlier.) > > >> >> >> >>> > > > >> >> >> >>> > The vote is open for 72 hours, or until the necessary > number > > > of > > >> >> >> >>> > binding votes (3 +1) is reached. > > >> >> >> >>> > > > >> >> >> >>> > [ ] +1 Release this package > > >> >> >> >>> > [ ] 0 I don't feel strongly about it, but I'm okay > with > > > the > > >> >> >> release > > >> >> >> >>> > [ ] -1 Do not release this package because... > > >> >> >> >>> > > > >> >> >> >>> > If this vote passes, we will start a 2nd vote at > > >> >> general@incubator. > > >> >> >> >>> > > > >> >> >> >>> > -- > > >> >> >> >>> > Thanks, > > >> >> >> >>> > Daniel Dekany > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > > >> >> >> >>> > > >> >> >> >>> -- > > >> >> >> >>> Thanks, > > >> >> >> >>> Daniel Dekany > > >> >> >> >>> > > >> >> >> >>> > > >> >> >> > > > >> >> >> > -- > > >> >> >> > Thanks, > > >> >> >> > Daniel Dekany > > >> >> >> > > >> >> >> > > >> >> > > > >> >> > > > >> >> > > > >> >> > > >> >> > > >> > > > >> > > > >> > > >> -- > > >> Thanks, > > >> Daniel Dekany > > >> > > > > > > > -- > Sergio Fernández > Partner Technology Manager > Redlink GmbH > m: +43 6602747925 > e: [email protected] <javascript:;> > w: http://redlink.co >
