[
https://issues.apache.org/jira/browse/GEODE-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729983#comment-15729983
]
ASF GitHub Bot commented on GEODE-1984:
---------------------------------------
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91390603
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -55,7 +55,7 @@ private CommandResult
executeCommandWithIgnoredExceptions(String command) {
* GatewaySender with all default attributes
--- End diff --
Would it make sense to create different tests for destroy and keep them
separate from testing create? That way when a test fails we know exactly what
is failing (create vs destroy).
> Make GatewaySender destroy a public API
> ---------------------------------------
>
> Key: GEODE-1984
> URL: https://issues.apache.org/jira/browse/GEODE-1984
> Project: Geode
> Issue Type: New Feature
> Components: wan
> Reporter: Barry Oglesby
> Assignee: Avinash Dongre
>
> The internal {{AbstractGatewaySender}} class has a {{destroy}} API to destroy
> a {{GatewaySender}}. This is currently an internal API. It would be nice to
> make this public by:
> - adding destroy to the {{GatewaySender}} interface
> - provide {{gfsh}} support
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
