[
https://issues.apache.org/jira/browse/GEODE-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730497#comment-15730497
]
ASF GitHub Bot commented on GEODE-1984:
---------------------------------------
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91422209
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ---
@@ -400,4 +400,19 @@
public int getMaxParallelismForReplicatedRegion();
+
+ /**
+ * Destroys the GatewaySender. Before destroying the sender, caller
needs to to ensure that the
+ * sender is stopped so that all the resources (threads, connection pool
etc.) will be released
+ * properly. Stopping the sender is not handled in the destroy. Destroy
is carried out in
+ * following steps: 1. Take the lifeCycleLock. 2. If the sender is
attached to any application
+ * region, throw an exception. 3. Close the GatewaySenderAdvisor. 4.
Remove the sender from the
+ * cache. 5. Destroy the region underlying the GatewaySender.
+ * <p>
+ * In case of ParallelGatewaySender, the destroy operation does
distributed destroy of the QPR. In
+ * case of SerialGatewaySender, the queue region is destroyed locally.
--- End diff --
Fixed.
> Make GatewaySender destroy a public API
> ---------------------------------------
>
> Key: GEODE-1984
> URL: https://issues.apache.org/jira/browse/GEODE-1984
> Project: Geode
> Issue Type: New Feature
> Components: docs, wan
> Reporter: Barry Oglesby
> Assignee: Avinash Dongre
>
> The internal {{AbstractGatewaySender}} class has a {{destroy}} API to destroy
> a {{GatewaySender}}. This is currently an internal API. It would be nice to
> make this public by:
> - adding destroy to the {{GatewaySender}} interface
> - provide {{gfsh}} support
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
