[
https://issues.apache.org/jira/browse/GEODE-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730672#comment-15730672
]
ASF GitHub Bot commented on GEODE-1984:
---------------------------------------
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91423780
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -282,13 +335,40 @@ public void
testCreateGatewaySenderWithGatewayEventFilters() {
1000, 5000, true, false, 1000, 100, 2, OrderPolicy.THREAD,
eventFilters, null));
vm5.invoke(() -> verifySenderAttributes("ln", 2, false, true, 1000,
socketReadTimeout, true,
1000, 5000, true, false, 1000, 100, 2, OrderPolicy.THREAD,
eventFilters, null));
+
+ // Test Destroy Command.
+ command =
+ CliStrings.DESTROY_GATEWAYSENDER + " --" +
CliStrings.DESTROY_GATEWAYSENDER__ID + "=ln";
--- End diff --
This code looks copy pasted in other areas, any way we can pull it into a
separate method for reuse?
> Make GatewaySender destroy a public API
> ---------------------------------------
>
> Key: GEODE-1984
> URL: https://issues.apache.org/jira/browse/GEODE-1984
> Project: Geode
> Issue Type: New Feature
> Components: docs, wan
> Reporter: Barry Oglesby
> Assignee: Avinash Dongre
>
> The internal {{AbstractGatewaySender}} class has a {{destroy}} API to destroy
> a {{GatewaySender}}. This is currently an internal API. It would be nice to
> make this public by:
> - adding destroy to the {{GatewaySender}} interface
> - provide {{gfsh}} support
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
