[ 
https://issues.apache.org/jira/browse/GEODE-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730483#comment-15730483
 ] 

ASF GitHub Bot commented on GEODE-1984:
---------------------------------------

Github user davinash commented on a diff in the pull request:

    https://github.com/apache/geode/pull/303#discussion_r91421904
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ---
    @@ -400,4 +400,19 @@
     
       public int getMaxParallelismForReplicatedRegion();
     
    +
    +  /**
    +   * Destroys the GatewaySender. Before destroying the sender, caller 
needs to to ensure that the
    --- End diff --
    
    Fixed.


> Make GatewaySender destroy a public API
> ---------------------------------------
>
>                 Key: GEODE-1984
>                 URL: https://issues.apache.org/jira/browse/GEODE-1984
>             Project: Geode
>          Issue Type: New Feature
>          Components: docs, wan
>            Reporter: Barry Oglesby
>            Assignee: Avinash Dongre
>
> The internal {{AbstractGatewaySender}} class has a {{destroy}} API to destroy 
> a {{GatewaySender}}. This is currently an internal API. It would be nice to 
> make this public by:
> - adding destroy to the {{GatewaySender}} interface
> - provide {{gfsh}} support



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to