[
https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422886#comment-13422886
]
Hyunsik Choi commented on GIRAPH-259:
-------------------------------------
The patch looks good.
But, did you do unittest?
I'm getting one fail and one error from this patch.
{noformat}
Results :
Failed tests:
testBspMasterCompute(org.apache.giraph.TestBspBasic)
Tests in error:
testBspPageRankWithAggregatorWriter(org.apache.giraph.TestBspBasic)
Tests run: 94, Failures: 1, Errors: 1, Skipped: 0
{noformat}
> TestBspBasic.testBspPageRank is broken
> --------------------------------------
>
> Key: GIRAPH-259
> URL: https://issues.apache.org/jira/browse/GIRAPH-259
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-259-1.patch
>
>
> Test crashes on line 152 in class SimplePageRankVertex in distributed mode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
