[
https://issues.apache.org/jira/browse/GOBBLIN-1656?focusedWorklogId=784909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784909
]
ASF GitHub Bot logged work on GOBBLIN-1656:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 02:15
Start Date: 27/Jun/22 02:15
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3516:
URL: https://github.com/apache/gobblin/pull/3516#discussion_r906920295
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/UserQuotaManager.java:
##########
@@ -103,8 +108,16 @@ public void checkQuota(Dag.DagNode<JobExecutionPlan>
dagNode, boolean onInit) th
boolean requesterCheck = true;
if (serializedRequesters != null) {
- List<String> uniqueRequesters =
RequesterService.deserialize(serializedRequesters).stream()
-
.map(ServiceRequester::getName).distinct().collect(Collectors.toList());
+ List<String> uniqueRequesters;
+ try {
+ uniqueRequesters = RequesterService.deserialize(serializedRequesters)
+ .stream()
+ .map(ServiceRequester::getName)
+ .distinct()
+ .collect(Collectors.toList());
+ } catch (IOException e) {
+ throw new RuntimeException("Could not process requesters due to ", e);
+ }
Review Comment:
`return new ObjectMapper().readValue(jsonList, mapType);` throws an
IOException as well, so we'd wrap that into a RuntimeException? I think that's
appropriate given that it's not likely handleable outside of logging.
Issue Time Tracking
-------------------
Worklog Id: (was: 784909)
Time Spent: 3h 10m (was: 3h)
> Return different Http Status on GaaS if Quota is Exceeded
> ---------------------------------------------------------
>
> Key: GOBBLIN-1656
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1656
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> GaaS has quota limits for proxy users and flowGroups.
> When a user wants to create a flow that exceeds their specified quota, the
> flow should
> 1) Not be run
> 2) Return a http status code (i.e. 503) due to exceeding the resource. This
> allows clients to implement some wait and retry functionality
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
