[
https://issues.apache.org/jira/browse/GOBBLIN-1656?focusedWorklogId=793924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793924
]
ASF GitHub Bot logged work on GOBBLIN-1656:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/22 20:16
Start Date: 21/Jul/22 20:16
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3516:
URL: https://github.com/apache/gobblin/pull/3516#discussion_r927066784
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java:
##########
@@ -181,6 +183,8 @@ public UpdateResponse updateFlowConfig(FlowId flowId,
FlowConfig flowConfig, boo
throw new RestLiServiceException(HttpStatus.S_503_SERVICE_UNAVAILABLE,
e.getMessage());
} catch (Throwable e) {
// TODO: Compilation errors should fall under throwable exceptions as
well instead of checking for strings
Review Comment:
I can make a ticket for it, but right now the flow compilation process is
really descriptive what is missing, and users would see a generic HTTP status
400 error with a "Path does not exist" due to failing compilation. I think if
we utilized exceptions rather than that compilation check it would be easier to
differentiate and reason about.
Issue Time Tracking
-------------------
Worklog Id: (was: 793924)
Time Spent: 5.5h (was: 5h 20m)
> Return different Http Status on GaaS if Quota is Exceeded
> ---------------------------------------------------------
>
> Key: GOBBLIN-1656
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1656
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> GaaS has quota limits for proxy users and flowGroups.
> When a user wants to create a flow that exceeds their specified quota, the
> flow should
> 1) Not be run
> 2) Return a http status code (i.e. 503) due to exceeding the resource. This
> allows clients to implement some wait and retry functionality
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
