[
https://issues.apache.org/jira/browse/GOBBLIN-1656?focusedWorklogId=786507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786507
]
ASF GitHub Bot logged work on GOBBLIN-1656:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/22 10:22
Start Date: 30/Jun/22 10:22
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3516:
URL: https://github.com/apache/gobblin/pull/3516#discussion_r910859880
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java:
##########
@@ -133,7 +134,13 @@ public CreateResponse createFlowConfig(FlowConfig
flowConfig, boolean triggerLis
if (!flowConfig.hasSchedule() &&
this.flowCatalog.exists(flowSpec.getUri())) {
return new CreateResponse(new ComplexResourceKey<>(flowConfig.getId(),
new EmptyRecord()), HttpStatus.S_409_CONFLICT);
} else {
- this.flowCatalog.put(flowSpec, triggerListener);
+ try {
+ this.flowCatalog.put(flowSpec, triggerListener);
+ } catch (Throwable e) {
+ if (e instanceof QuotaExceededException) {
Review Comment:
just musing for a moment... would it be equivalent to phrase as simply?
```
} catch (QuotaExceededException e) {
throw new ...
```
? (i.e. let the `catch` do the RTTI for you implicitly)
Issue Time Tracking
-------------------
Worklog Id: (was: 786507)
Time Spent: 4h 40m (was: 4.5h)
> Return different Http Status on GaaS if Quota is Exceeded
> ---------------------------------------------------------
>
> Key: GOBBLIN-1656
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1656
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> GaaS has quota limits for proxy users and flowGroups.
> When a user wants to create a flow that exceeds their specified quota, the
> flow should
> 1) Not be run
> 2) Return a http status code (i.e. 503) due to exceeding the resource. This
> allows clients to implement some wait and retry functionality
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
