[
https://issues.apache.org/jira/browse/GOBBLIN-1775?focusedWorklogId=843962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843962
]
ASF GitHub Bot logged work on GOBBLIN-1775:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/23 02:24
Start Date: 07/Feb/23 02:24
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3633:
URL: https://github.com/apache/gobblin/pull/3633#discussion_r1098109140
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -232,12 +222,69 @@ public void write(GobblinMetadataChangeEvent gmce,
Map<String, Collection<HiveSp
break;
}
default: {
- log.error("unsupported operation {}",
gmce.getOperationType().toString());
+ log.error("unsupported operation {}", opType);
return;
}
}
}
+ /**
+ * Helper function to gracefully handle errors when creating a hive table.
Existence is not an error.
Review Comment:
Maybe the wording here is confusing. What I am trying to convey is that
Existence of the table when making this call still returns true. What do you
think of the following wording instead?
> If the table existed before calling this method, the method will still
return true
The reason I even chose to add this wording is because the underlying call
is `createTableIfNotExists`, which returns false if the table already existed.
```
/**
* Create a Hive table if not exists.
*
* @param table a {@link HiveTable} to be created.
* @return true if the table is successfully created; false if the table
already exists.
* @throws IOException
*/
public abstract boolean createTableIfNotExists(HiveTable table)
throws IOException;
```
Issue Time Tracking
-------------------
Worklog Id: (was: 843962)
Time Spent: 40m (was: 0.5h)
> Add logic in GMIP to not fail the container when we cannot create table
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1775
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1775
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
