[
https://issues.apache.org/jira/browse/GOBBLIN-1775?focusedWorklogId=845235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845235
]
ASF GitHub Bot logged work on GOBBLIN-1775:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/23 23:55
Start Date: 13/Feb/23 23:55
Worklog Time Spent: 10m
Work Description: jack-moseley commented on code in PR #3633:
URL: https://github.com/apache/gobblin/pull/3633#discussion_r1105139677
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -281,15 +281,24 @@ private boolean inHiveSpecCache(String tableKey) {
}
private void updateLatestSchemaMapWithExistingSchema(String dbName, String
tableName, String tableKey) throws IOException {
+ updateLatestSchemaMapWithExistingSchema(dbName, tableName, tableKey,
useExistingTableSchemaAllowDenyList, hiveRegister, latestSchemaMap);
+ }
+
+ // returns if latest schema map was updated with the existing schema in Hive
Review Comment:
Meant to say "returns true if"?
##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/HiveMetadataWriterTest.java:
##########
@@ -350,6 +403,34 @@ private String writeRecord(File file) throws IOException {
return path;
}
+ /**
+ * Test class for exposing methods for exposing internal HiveMetaWriter
functions without making them public.
Review Comment:
Typo
"Test class ~~for exposing methods~~ for exposing internal HiveMetaWriter
functions"
Issue Time Tracking
-------------------
Worklog Id: (was: 845235)
Time Spent: 1h 20m (was: 1h 10m)
> Add logic in GMIP to not fail the container when we cannot create table
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1775
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1775
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
