[
https://issues.apache.org/jira/browse/GOBBLIN-1775?focusedWorklogId=845244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845244
]
ASF GitHub Bot logged work on GOBBLIN-1775:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/23 00:18
Start Date: 14/Feb/23 00:18
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3633:
URL: https://github.com/apache/gobblin/pull/3633#discussion_r1105154240
##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/HiveMetadataWriterTest.java:
##########
@@ -80,6 +82,10 @@
import org.apache.gobblin.stream.RecordEnvelope;
import org.apache.gobblin.util.ClustersNames;
import org.apache.gobblin.util.ConfigUtils;
+import org.apache.gobblin.util.function.CheckedExceptionFunction;
+import org.mockito.Mockito;
+
+import static org.mockito.Matchers.eq;
public class HiveMetadataWriterTest extends HiveMetastoreTest {
Review Comment:
The writer lives in in gobblin-hive-registration. And the test lives in
gobblin iceberg.
Your suspicion is correct. The problem is that this test relies on some hive
testing utilities in the iceberg module. It's a bit of a mess to move it there
and the benefit is not worth it
Issue Time Tracking
-------------------
Worklog Id: (was: 845244)
Time Spent: 1h 50m (was: 1h 40m)
> Add logic in GMIP to not fail the container when we cannot create table
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1775
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1775
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
