[
https://issues.apache.org/jira/browse/GOBBLIN-1775?focusedWorklogId=845240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845240
]
ASF GitHub Bot logged work on GOBBLIN-1775:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/23 00:06
Start Date: 14/Feb/23 00:06
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3633:
URL: https://github.com/apache/gobblin/pull/3633#discussion_r1105147057
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -281,15 +281,24 @@ private boolean inHiveSpecCache(String tableKey) {
}
private void updateLatestSchemaMapWithExistingSchema(String dbName, String
tableName, String tableKey) throws IOException {
+ updateLatestSchemaMapWithExistingSchema(dbName, tableName, tableKey,
useExistingTableSchemaAllowDenyList, hiveRegister, latestSchemaMap);
+ }
+
+ // returns if latest schema map was updated with the existing schema in Hive
+ @VisibleForTesting
+ protected static boolean updateLatestSchemaMapWithExistingSchema(String
dbName, String tableName, String tableKey,
Review Comment:
Yeah just for testing purposes.
Issue Time Tracking
-------------------
Worklog Id: (was: 845240)
Time Spent: 1h 40m (was: 1.5h)
> Add logic in GMIP to not fail the container when we cannot create table
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1775
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1775
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
