[
https://issues.apache.org/jira/browse/GOBBLIN-1786?focusedWorklogId=848470&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848470
]
ASF GitHub Bot logged work on GOBBLIN-1786:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/23 22:37
Start Date: 01/Mar/23 22:37
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1122366528
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -319,11 +320,11 @@ protected static Optional<URI>
getAsOptionalURI(Properties props, String key) {
}
protected DatasetDescriptor getSourceDataset(FileSystem sourceFs) {
- return getDatasetDescriptor(sourceCatalogMetastoreURI, sourceFs);
+ return getDatasetDescriptor(sourceCatalogURI, sourceFs);
Review Comment:
is this a dataset-level descriptor? seems it would be the same for all
datasets from the same catalog, rather than distinct for each... is that really
sufficient?
perhaps `IcebergTable` deserves a (table-specific)
`getDatasetDescriptor(FileSystem)` method?
Issue Time Tracking
-------------------
Worklog Id: (was: 848470)
Time Spent: 5h 40m (was: 5.5h)
> Support Other Catalog Types for Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-1786
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1786
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
