[
https://issues.apache.org/jira/browse/GOBBLIN-1786?focusedWorklogId=848476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848476
]
ASF GitHub Bot logged work on GOBBLIN-1786:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/23 00:15
Start Date: 02/Mar/23 00:15
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1122461100
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -319,11 +320,11 @@ protected static Optional<URI>
getAsOptionalURI(Properties props, String key) {
}
protected DatasetDescriptor getSourceDataset(FileSystem sourceFs) {
- return getDatasetDescriptor(sourceCatalogMetastoreURI, sourceFs);
+ return getDatasetDescriptor(sourceCatalogURI, sourceFs);
Review Comment:
I see, it would be a dataset level descriptor since the `fileSetId` captures
the dbName and tableName. However, I agree that perhaps we should have this
method inside `IcebergTable` and call the dataset descriptor for src and dest
accordingly. I have made the changes and pushed it in my latest commit!
Issue Time Tracking
-------------------
Worklog Id: (was: 848476)
Time Spent: 5h 50m (was: 5h 40m)
> Support Other Catalog Types for Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-1786
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1786
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
