[
https://issues.apache.org/jira/browse/GOBBLIN-1786?focusedWorklogId=847598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847598
]
ASF GitHub Bot logged work on GOBBLIN-1786:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/23 00:48
Start Date: 25/Feb/23 00:48
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1117832026
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergCatalog.java:
##########
@@ -17,10 +17,25 @@
package org.apache.gobblin.data.management.copy.iceberg;
+import org.apache.iceberg.catalog.Catalog;
+
/**
* Any catalog from which to access {@link IcebergTable}s.
*/
public interface IcebergCatalog {
IcebergTable openTable(String dbName, String tableName);
+ String getCatalogUri();
+
+ /**
+ * Adding a sub interface to help us provide an association between {@link
Catalog} and {@link IcebergCatalog}.
+ * This helps us resolve to the Catalog to its concrete implementation class
+ * Primarily needed to access `newTableOps` method which only certain {@link
Catalog} derived classes open for public access
+ */
+ interface CatalogSpecifier {
Review Comment:
Yes, I mean if we are sure that a specific GobblinIcebergCatalog only
supports one type of native iceberg catalog as you mentioned above, i.e.
IcebergHiveCatalog only supports HiveCatalog, then I think it's better to have
IcebergHiveCatalog to hardcode HiveCatalog, and a job just needs to tell that
it needs to use IcebergHiveCatalog.
If we are saying one GobblinIcebergCatalog can support different types of
native iceberg catalogs, then we should separate the config into two to make it
more flexible. Let's say we have icebergCatalog, and if I want to use FsCatalog
in the future, it does not make sense for me to create another specifier class
that does nothing but just combines icebergCatalog and FsCatalog.
Issue Time Tracking
-------------------
Worklog Id: (was: 847598)
Time Spent: 4.5h (was: 4h 20m)
> Support Other Catalog Types for Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-1786
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1786
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
