[
https://issues.apache.org/jira/browse/GOBBLIN-1786?focusedWorklogId=848457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848457
]
ASF GitHub Bot logged work on GOBBLIN-1786:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/23 21:10
Start Date: 01/Mar/23 21:10
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1122301399
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetFinder.java:
##########
@@ -21,19 +21,25 @@
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
+import java.util.Map;
+import java.util.Optional;
import java.util.Properties;
import org.apache.commons.lang.StringUtils;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
+import com.google.api.client.util.Maps;
Review Comment:
Still see this dep? You can remove it if it's a dead import
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergCatalogFactory.java:
##########
@@ -17,20 +17,24 @@
package org.apache.gobblin.data.management.copy.iceberg;
+import java.io.IOException;
+import java.util.Map;
import org.apache.hadoop.conf.Configuration;
-import org.apache.iceberg.hive.HiveCatalog;
-
-import com.google.common.collect.Maps;
+import org.apache.gobblin.util.reflection.GobblinConstructorUtils;
/**
* Provides an {@link IcebergCatalog}.
*/
public class IcebergCatalogFactory {
- public static IcebergCatalog create(Configuration configuration) {
- HiveCatalog hcat = new HiveCatalog();
- hcat.setConf(configuration);
- hcat.initialize("hive", Maps.newHashMap());
- return new IcebergHiveCatalog(hcat);
+ public static IcebergCatalog create(String icebergCatalogType, Map<String,
String> properties, Configuration configuration) throws IOException {
Review Comment:
Can you rename `icebergCatalogType` to `icebergCatalogClassName`
Issue Time Tracking
-------------------
Worklog Id: (was: 848457)
Time Spent: 5h (was: 4h 50m)
> Support Other Catalog Types for Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-1786
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1786
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
