[ 
https://issues.apache.org/jira/browse/GOBBLIN-1813?focusedWorklogId=856573&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856573
 ]

ASF GitHub Bot logged work on GOBBLIN-1813:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/23 21:12
            Start Date: 12/Apr/23 21:12
    Worklog Time Spent: 10m 
      Work Description: homatthew commented on code in PR #3677:
URL: https://github.com/apache/gobblin/pull/3677#discussion_r1164658958


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallable.java:
##########
@@ -326,7 +327,10 @@ private void runJobExecutionLauncher() throws JobException 
{
         // make sure the planning job is initialized (or visible) to other 
parallel running threads,
         // so that the same critical section check (querying Helix for job 
completeness)
         // can be applied.
-        HelixUtils.waitJobInitialization(planningJobHelixManager, 
newPlanningId, newPlanningId);
+        Duration submissionTimeout = Duration.ofSeconds(PropertiesUtils

Review Comment:
   The planning job (i.e. distributed mode) is used in GaaS. This change is 
usable by GaaS in the event that GaaS also sees similar Helix / ZK bottlenecks. 
   
   The default is the same as the previous 5 minute wait, so it is backwards 
compatible





Issue Time Tracking
-------------------

    Worklog Id:     (was: 856573)
    Time Spent: 20m  (was: 10m)

> Helix workflow submissions from Gobblin should have a configurable timeout
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1813
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1813
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to