[
https://issues.apache.org/jira/browse/GOBBLIN-1813?focusedWorklogId=856576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856576
]
ASF GitHub Bot logged work on GOBBLIN-1813:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/23 21:14
Start Date: 12/Apr/23 21:14
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3677:
URL: https://github.com/apache/gobblin/pull/3677#discussion_r1164660571
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java:
##########
@@ -112,22 +117,11 @@ public static String getHelixInstanceName(
return namePrefix + "_" + instanceId;
}
- // We have switched from Helix JobQueue to WorkFlow based job execution.
- @Deprecated
- public static void submitJobToQueue(
- JobConfig.Builder jobConfigBuilder,
- String queueName,
- String jobName,
- TaskDriver helixTaskDriver,
- HelixManager helixManager,
- long jobQueueDeleteTimeoutSeconds) throws Exception {
- submitJobToWorkFlow(jobConfigBuilder, queueName, jobName, helixTaskDriver,
helixManager, jobQueueDeleteTimeoutSeconds);
- }
-
static void waitJobInitialization(
HelixManager helixManager,
String workFlowName,
- String jobName) throws Exception {
+ String jobName,
+ Duration timeout) throws Exception {
Review Comment:
I also considered having an overloaded method with a default timeout. But I
think it makes more sense to enforce all callers of this method to specify a
timeout / have that timeout be configurable. Code changes are a slow way to fix
prod issues, and config is preferred
Issue Time Tracking
-------------------
Worklog Id: (was: 856576)
Time Spent: 40m (was: 0.5h)
> Helix workflow submissions from Gobblin should have a configurable timeout
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1813
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1813
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
