[
https://issues.apache.org/jira/browse/GOBBLIN-1813?focusedWorklogId=856589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856589
]
ASF GitHub Bot logged work on GOBBLIN-1813:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/23 22:47
Start Date: 12/Apr/23 22:47
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3677:
URL: https://github.com/apache/gobblin/pull/3677#discussion_r1164730248
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -447,11 +455,11 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
if (this.runningMap.replace(this.jobContext.getJobName(), false, true)) {
LOGGER.info("Job {} will be executed, add into running map.",
this.jobContext.getJobId());
isLaunched = true;
- super.launchJob(jobListener);
+ launchJobImpl(jobListener);
} else {
LOGGER.warn("Job {} will not be executed because other jobs are still
running.", this.jobContext.getJobId());
}
- // TODO: Better error handling
+ // TODO: Better error handling. The current impl swallows exceptions for
jobs that were started by this method call
} catch (Throwable t) {
Review Comment:
Add todo here to make the behavior of swallowing exception configurable
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java:
##########
@@ -112,22 +117,11 @@ public static String getHelixInstanceName(
return namePrefix + "_" + instanceId;
}
- // We have switched from Helix JobQueue to WorkFlow based job execution.
- @Deprecated
- public static void submitJobToQueue(
- JobConfig.Builder jobConfigBuilder,
- String queueName,
- String jobName,
- TaskDriver helixTaskDriver,
- HelixManager helixManager,
- long jobQueueDeleteTimeoutSeconds) throws Exception {
- submitJobToWorkFlow(jobConfigBuilder, queueName, jobName, helixTaskDriver,
helixManager, jobQueueDeleteTimeoutSeconds);
- }
-
static void waitJobInitialization(
HelixManager helixManager,
String workFlowName,
- String jobName) throws Exception {
+ String jobName,
+ Duration timeout) throws Exception {
Review Comment:
Just curious here why do we choose to use duration here? Why not use long
directly to represent timeout mills?
Issue Time Tracking
-------------------
Worklog Id: (was: 856589)
Time Spent: 50m (was: 40m)
> Helix workflow submissions from Gobblin should have a configurable timeout
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1813
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1813
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
