[ 
https://issues.apache.org/jira/browse/GOBBLIN-1813?focusedWorklogId=856600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856600
 ]

ASF GitHub Bot logged work on GOBBLIN-1813:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/23 23:46
            Start Date: 12/Apr/23 23:46
    Worklog Time Spent: 10m 
      Work Description: homatthew commented on code in PR #3677:
URL: https://github.com/apache/gobblin/pull/3677#discussion_r1164769313


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java:
##########
@@ -235,7 +229,8 @@ public static void submitJobToWorkFlow(JobConfig.Builder 
jobConfigBuilder,
       String jobName,
       TaskDriver helixTaskDriver,
       HelixManager helixManager,
-      long workFlowExpiryTime) throws Exception {
+      long workFlowExpiryTime,

Review Comment:
   Leaving this as a long is inconsistent. I'll change this to duration





Issue Time Tracking
-------------------

    Worklog Id:     (was: 856600)
    Time Spent: 1h 10m  (was: 1h)

> Helix workflow submissions from Gobblin should have a configurable timeout
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1813
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1813
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to