[ 
https://issues.apache.org/jira/browse/GOBBLIN-1969?focusedWorklogId=893494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893494
 ]

ASF GitHub Bot logged work on GOBBLIN-1969:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Dec/23 00:18
            Start Date: 02/Dec/23 00:18
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3840:
URL: https://github.com/apache/gobblin/pull/3840#discussion_r1412677033


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java:
##########
@@ -76,8 +76,9 @@ public class DagManagerMetrics {
   private final Map<String, ContextAwareMeter> executorSlaExceededMeters = 
Maps.newConcurrentMap();
   private final Map<String, ContextAwareMeter> executorJobSentMeters = 
Maps.newConcurrentMap();
 
-  // Metrics for unexpected flow handling failures
+  // Metric for unexpected flow handling failures
   private ContextAwareCounter failedLaunchEventsOnActivationCount;
+  private ContextAwareCounter successfulLaunchEventsOnActivationCount;

Review Comment:
   now these are for flow handling **outcomes** (although only for startup, so 
not in the general sense)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 893494)
    Time Spent: 0.5h  (was: 20m)

> Increase Visibility for Compilation Failures
> --------------------------------------------
>
>                 Key: GOBBLIN-1969
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1969
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Empty or null dag execution plans created after compiling do not provide 
> sufficient information as to when and why they occur. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to