[
https://issues.apache.org/jira/browse/GOBBLIN-1969?focusedWorklogId=893871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893871
]
ASF GitHub Bot logged work on GOBBLIN-1969:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/23 20:25
Start Date: 04/Dec/23 20:25
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3840:
URL: https://github.com/apache/gobblin/pull/3840#discussion_r1414446166
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -86,10 +86,16 @@ public Optional<Dag<JobExecutionPlan>>
createExecutionPlanIfValid(FlowSpec flowS
Map<String, String> flowMetadata =
TimingEventUtils.getFlowMetadata(flowSpec);
if (!jobExecutionPlanDagOptional.isPresent()) {
+ log.warn("No dag execution plan created for flowGroup: {} flowName: {}",
+ flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_GROUP_FIELD),
+ flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_NAME_FIELD));
Review Comment:
if we do anything other than logging the value, I recommend a default (even
when it *should* always be set). for logging only, it's safe enough to print
`null`, when that's what's actually returned.
Issue Time Tracking
-------------------
Worklog Id: (was: 893871)
Time Spent: 1h 20m (was: 1h 10m)
> Increase Visibility for Compilation Failures
> --------------------------------------------
>
> Key: GOBBLIN-1969
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1969
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Empty or null dag execution plans created after compiling do not provide
> sufficient information as to when and why they occur.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
