[
https://issues.apache.org/jira/browse/GOBBLIN-1969?focusedWorklogId=893493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893493
]
ASF GitHub Bot logged work on GOBBLIN-1969:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/23 00:18
Start Date: 02/Dec/23 00:18
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3840:
URL: https://github.com/apache/gobblin/pull/3840#discussion_r1412677033
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java:
##########
@@ -76,8 +76,9 @@ public class DagManagerMetrics {
private final Map<String, ContextAwareMeter> executorSlaExceededMeters =
Maps.newConcurrentMap();
private final Map<String, ContextAwareMeter> executorJobSentMeters =
Maps.newConcurrentMap();
- // Metrics for unexpected flow handling failures
+ // Metric for unexpected flow handling failures
private ContextAwareCounter failedLaunchEventsOnActivationCount;
+ private ContextAwareCounter successfulLaunchEventsOnActivationCount;
Review Comment:
now these are for flow handling outcomes (although they're both only for
startup, so not in the general sense)
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceGuiceModule.java:
##########
@@ -200,6 +200,12 @@ public void configure(Binder binder) {
ServiceConfigKeys.TOPOLOGYSPEC_FACTORY_KEY,
ServiceConfigKeys.DEFAULT_TOPOLOGY_SPEC_FACTORY));
}
+ // Initialize flow catalog before DagManager is enabled so templates are
loaded when initializing the DagManager
Review Comment:
I'm not too familiar w/ Guice... but are you sure the call to `binder.bind`
is guaranteed to synchronously carryout "initializing the flow catalog" (so
that finishes before the later call to `binder.bind(DagManager.class)`)?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java:
##########
@@ -212,6 +216,13 @@ public void incrementFailedLaunchCount() {
}
}
+ // Increment the count for num of successful launches attempted during
leader activation
+ public void incrementSuccessfulLaunchAttemptCount() {
Review Comment:
I see the comment above (should be javadoc), but the method name invites
confusion, since it sounds like this is for counting successes, irrespective of
whether or not during startup
(BTW, "system startup" is slightly more accurate for our multi-leader arch
than "leader activation" )
Issue Time Tracking
-------------------
Worklog Id: (was: 893493)
Time Spent: 20m (was: 10m)
> Increase Visibility for Compilation Failures
> --------------------------------------------
>
> Key: GOBBLIN-1969
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1969
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Empty or null dag execution plans created after compiling do not provide
> sufficient information as to when and why they occur.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
