[
https://issues.apache.org/jira/browse/GOBBLIN-1969?focusedWorklogId=893496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893496
]
ASF GitHub Bot logged work on GOBBLIN-1969:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/23 00:20
Start Date: 02/Dec/23 00:20
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3840:
URL: https://github.com/apache/gobblin/pull/3840#discussion_r1412678292
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java:
##########
@@ -212,6 +216,13 @@ public void incrementFailedLaunchCount() {
}
}
+ // Increment the count for num of successful launches attempted during
leader activation
+ public void incrementSuccessfulLaunchAttemptCount() {
Review Comment:
I see the comment above (that arguably should be javadoc), but the method
name invites confusion, since it sounds like this is for counting successes,
irrespective of whether or not during startup
(BTW, "system startup" is slightly more accurate for our multi-leader arch
than is "leader activation" )
Issue Time Tracking
-------------------
Worklog Id: (was: 893496)
Time Spent: 50m (was: 40m)
> Increase Visibility for Compilation Failures
> --------------------------------------------
>
> Key: GOBBLIN-1969
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1969
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Empty or null dag execution plans created after compiling do not provide
> sufficient information as to when and why they occur.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
