phet commented on code in PR #3846:
URL: https://github.com/apache/gobblin/pull/3846#discussion_r1425987653
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -299,7 +304,7 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
// Depending on if DagManager is present, handle execution
if (this.dagManager.isPresent()) {
- submitFlowToDagManager((FlowSpec) spec, jobExecutionPlanDag);
+ submitFlowToDagManager(flowSpec, jobExecutionPlanDag);
Review Comment:
let's consider dropping support for running GaaS w/o the DagManager. what
are your thoughts @Will-Lo ?
(not as part of this PR, but as a follow-up in the next month or so)
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -342,6 +348,15 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
Instrumented.updateTimer(this.flowOrchestrationTimer, System.nanoTime() -
startTime, TimeUnit.NANOSECONDS);
}
+ /*
+ Deletes spec from flowCatalog if it is an adhoc flow (not containing a job
schedule)
+ */
+ private void deleteSpecFromCatalogIfAdhoc(FlowSpec flowSpec) {
Review Comment:
nit: `private` methods like this belong beneath the `public` and `protected`
ones
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -248,7 +253,7 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
Instrumented.markMeter(this.flowOrchestrationFailedMeter);
return;
}
- Map<String, String> flowMetadata =
TimingEventUtils.getFlowMetadata((FlowSpec) spec);
+ Map<String, String> flowMetadata =
TimingEventUtils.getFlowMetadata(flowSpec);
Review Comment:
much nicer to get rid of those casts so far separated from the `instanceof`
check!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
