umustafi commented on code in PR #3846:
URL: https://github.com/apache/gobblin/pull/3846#discussion_r1427009648


##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobSchedulerTest.java:
##########
@@ -338,6 +338,7 @@ public void testJobSchedulerAddFlowQuotaExceeded() throws 
Exception {
     serviceLauncher.addService(flowCatalog);
     serviceLauncher.start();
 
+    // We need to test adhoc flows since scheduled flows do not have a quota 
check in the scheduler

Review Comment:
   When I tried to test scheduled run immediately flows I saw this code block 
and see its only for adhoc 
https://github.com/apache/gobblin/blob/99a1aae8940d1854d4de83d726013e4972d71c55/gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java#L565



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to