Will-Lo commented on code in PR #3846:
URL: https://github.com/apache/gobblin/pull/3846#discussion_r1426096385
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -299,7 +304,7 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
// Depending on if DagManager is present, handle execution
if (this.dagManager.isPresent()) {
- submitFlowToDagManager((FlowSpec) spec, jobExecutionPlanDag);
+ submitFlowToDagManager(flowSpec, jobExecutionPlanDag);
Review Comment:
Yeah I think we shouldn't need to support a scenario where dagmanager is
optional given how important it is for lifecycle management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
