arjun4084346 commented on code in PR #3846:
URL: https://github.com/apache/gobblin/pull/3846#discussion_r1426028845
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -359,6 +374,13 @@ public void submitFlowToDagManager(FlowSpec flowSpec,
Dag<JobExecutionPlan> jobE
try {
// Send the dag to the DagManager
this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+
+ /*
+ Adhoc flows can be deleted after persisting it in DagManager as the
DagManager's failure recovery method ensures
+ it will be executed in the event of downtime. Note that the
responsibility of the multi-active scheduler mode ends
+ after this method is completed AND the consumption of a launch type
event is committed to the consumer.
+ */
+ deleteSpecFromCatalogIfAdhoc(flowSpec);
Review Comment:
To confirm, did you check the callers of `FlowCatalog` `remove` method ? Is
it missing some case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
