[ 
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=901303&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901303
 ]

ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jan/24 02:09
            Start Date: 24/Jan/24 02:09
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1464212522


##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -328,23 +328,28 @@ public void testUncompilableJob() throws Exception {
     
Assert.assertFalse(this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(uri.toString()));
   }
 
-  @Test (dependsOnMethods = "testUncompilableJob")
+  // Disabled because of timing issue with scheduler
+  @Test (dependsOnMethods = "testUncompilableJob", enabled = false, groups = 
{"disabledOnCI"})

Review Comment:
   All these tests are very important and it is dangerous to disable them. We 
must find exactly what is the "timing" issue. I believe all kind of timing 
issues can be fixed if we know exactly what is the issue, what is the race 
condition.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 901303)
    Time Spent: 2h 50m  (was: 2h 40m)

> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
>                 Key: GOBBLIN-1990
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from 
> other unit tests. They frequently fail, showing different results on IDE 
> versus run in terminal with Gradle. We don't want to disable too many of them 
> since they are useful. However, we want to remove timing dependent tests and 
> decouple the tests so they do not depend on state from another test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to