[
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=902059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902059
]
ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/24 03:03
Start Date: 27/Jan/24 03:03
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1468286428
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -708,4 +788,11 @@ public void testGetFilteredFlowsPaginated() throws
Exception {
this.flowConfigClient.deleteFlowConfig(TEST_FLOW_ID6);
this.flowConfigClient.deleteFlowConfig(TEST_FLOW_ID7);
}
+
+ /*
+ Creates a unique flowId for a given group using the current timestamp as the
flowName.
+ */
+ public FlowId createFlowIdWithUniqueName(String groupName) {
Review Comment:
cool... is the same call ever made multiple times within the same test?
Issue Time Tracking
-------------------
Worklog Id: (was: 902059)
Time Spent: 4h 40m (was: 4.5h)
> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
> Key: GOBBLIN-1990
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from
> other unit tests. They frequently fail, showing different results on IDE
> versus run in terminal with Gradle. We don't want to disable too many of them
> since they are useful. However, we want to remove timing dependent tests and
> decouple the tests so they do not depend on state from another test.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)