[ 
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=902050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902050
 ]

ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/24 00:03
            Start Date: 27/Jan/24 00:03
    Worklog Time Spent: 10m 
      Work Description: umustafi commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1468249946


##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -339,60 +342,83 @@ public void testRunOnceJob() throws Exception {
     
AssertWithBackoff.create().maxSleepMs(200L).timeoutMs(2000L).backoffFactor(1)
         .assertTrue(input -> 
this.gobblinServiceManager.getFlowCatalog().getSpecs().size() == 0,
           "Waiting for job to get orchestrated...");
-    
AssertWithBackoff.create().maxSleepMs(100L).timeoutMs(1000L).backoffFactor(1)
-          .assertTrue(input -> 
!this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(TEST_URI.toString()),
-              "Waiting for job to get orchestrated...");
+    
AssertWithBackoff.create().maxSleepMs(100L).timeoutMs(2000L).backoffFactor(1)
+          .assertTrue(input -> 
!this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(uri.toString()),

Review Comment:
   I tried to verify it's present immediately after but I think it's processed 
immediately. It seems too timing dependent to have two assert with backoff 
statements, the first to check it's there, then to check it disappears. I'm not 
sure they would work. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 902050)
    Time Spent: 4h 20m  (was: 4h 10m)

> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
>                 Key: GOBBLIN-1990
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from 
> other unit tests. They frequently fail, showing different results on IDE 
> versus run in terminal with Gradle. We don't want to disable too many of them 
> since they are useful. However, we want to remove timing dependent tests and 
> decouple the tests so they do not depend on state from another test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to