[
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=902024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902024
]
ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/24 21:36
Start Date: 26/Jan/24 21:36
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1468170100
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -501,28 +578,29 @@ public void testDelete() throws Exception {
@Test (dependsOnMethods = "testDelete")
public void testGitCreate() throws Exception {
+ URI uri = FlowSpec.Utils.createFlowSpecUri(new
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName("testGitFlow"));
Review Comment:
Yes the renames is here to avoid collision. I couldn't figure out how to
pass a variable in the actual json (which is where the name of the flow comes
from not the file name), so I didn't want to separate the name only to hard
code it later.
Issue Time Tracking
-------------------
Worklog Id: (was: 902024)
Time Spent: 3h 50m (was: 3h 40m)
> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
> Key: GOBBLIN-1990
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from
> other unit tests. They frequently fail, showing different results on IDE
> versus run in terminal with Gradle. We don't want to disable too many of them
> since they are useful. However, we want to remove timing dependent tests and
> decouple the tests so they do not depend on state from another test.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)