[
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=901538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901538
]
ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/24 20:48
Start Date: 24/Jan/24 20:48
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1465519509
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -328,23 +328,28 @@ public void testUncompilableJob() throws Exception {
Assert.assertFalse(this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(uri.toString()));
}
- @Test (dependsOnMethods = "testUncompilableJob")
+ // Disabled because of timing issue with scheduler
+ @Test (dependsOnMethods = "testUncompilableJob", enabled = false, groups =
{"disabledOnCI"})
Review Comment:
We are disabling very few tests here, majority of the functionality is still
tested by other tests that have been updated in the PR (ie: create, get,
update, delete, getAll). It is worth fixing the other issues, but I am
proposing it's done in a separate PR.
Issue Time Tracking
-------------------
Worklog Id: (was: 901538)
Time Spent: 3h 10m (was: 3h)
> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
> Key: GOBBLIN-1990
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from
> other unit tests. They frequently fail, showing different results on IDE
> versus run in terminal with Gradle. We don't want to disable too many of them
> since they are useful. However, we want to remove timing dependent tests and
> decouple the tests so they do not depend on state from another test.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)