[
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=902899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902899
]
ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/24 20:40
Start Date: 31/Jan/24 20:40
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473411719
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java:
##########
@@ -206,6 +206,13 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
cancelJob(jobListener);
}
} finally {
+ // NOTE: This code only makes sense when there is 1 source / workflow
being launched per application. This is a stop-gap
+ // for recreating batch job behavior in GaaS. Given the current
constraints of yarn applications requiring a static proxy user
+ // during application creation, it is not possible to have multiple
workflows running in the same application.
Review Comment:
regarding what I just said about inheritance, this might be a situation
where that is in fact preferable to sticking opinionated behavior into a base
class.
e.g.:
1. this class is given no more than a hook w/ empty impl, say
`handleLaunchFinalization()`.
2. next create a derived class like `RunAndDoneGobblinJL` or
`TerminateAfterLaunchGJL` that sends the cluster shutdown request in an
override of the hook.
3. then leave it to the specific job launchers to either take on this
functionality or go w/o it by deciding which to extend.
Issue Time Tracking
-------------------
Worklog Id: (was: 902899)
Time Spent: 1h 20m (was: 1h 10m)
> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1996
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
