[
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=902833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902833
]
ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/24 15:40
Start Date: 31/Jan/24 15:40
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473042074
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalClusterManager.java:
##########
@@ -152,7 +141,7 @@ private void initializeAppLauncherAndServices() throws
Exception {
if (!properties.contains(ServiceBasedAppLauncher.APP_STOP_TIME_SECONDS)) {
properties.setProperty(ServiceBasedAppLauncher.APP_STOP_TIME_SECONDS,
Long.toString(300));
}
- this.applicationLauncher = new ServiceBasedAppLauncher(properties,
this.clusterName);
+ this.applicationLauncher = new
ServiceBasedAppLauncherWithoutMetrics(properties, this.clusterName);
Review Comment:
Metrics in these pipelines are causing noisy logging and the metrics here
are currently not used by Temporal this temporal in any meaningful way, so I've
disabled them here.
Disabling metrics via the gobblin metris key is not desirable because we
still need GTE emission to work
Issue Time Tracking
-------------------
Worklog Id: (was: 902833)
Time Spent: 20m (was: 10m)
> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1996
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
