[ 
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=902900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902900
 ]

ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Jan/24 20:40
            Start Date: 31/Jan/24 20:40
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473425614


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/ProcessWorkunitsSource.java:
##########
@@ -0,0 +1,75 @@
+package org.apache.gobblin.temporal.ddm;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+
+import com.google.common.eventbus.EventBus;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.configuration.SourceState;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.instrumented.extractor.InstrumentedExtractor;
+import org.apache.gobblin.source.InfiniteSource;
+import org.apache.gobblin.source.extractor.DataRecordException;
+import org.apache.gobblin.source.extractor.Extractor;
+import org.apache.gobblin.source.workunit.WorkUnit;
+import org.apache.gobblin.stream.RecordEnvelope;
+
+
+@Slf4j
+public class ProcessWorkunitsSource implements InfiniteSource {

Review Comment:
   `NoWorkunitsSource` or `EmptyWorkunitsSource`... doesn't seem to be anything 
processing specific
   
   (indeed may be confusing, as sources don't ever "process" WUs themself)
   
   finally... javadoc (and note importance of `InfiniteSource`, which I presume 
a key element)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 902900)
    Time Spent: 1.5h  (was: 1h 20m)

> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
>                 Key: GOBBLIN-1996
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to