homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473531890


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/app/ServiceBasedAppLauncher.java:
##########
@@ -163,9 +170,17 @@ public void run() {
     });
 
     LOG.info("Starting the Gobblin application and all its associated 
Services");
+    for (Service service : this.services) {
+      LOG.info("Starting service " + service.getClass().getSimpleName());
+    }
 
     // Start the application
-    this.serviceManager.startAsync().awaitHealthy();
+    try {
+      
this.serviceManager.startAsync().awaitHealthy(startupTimeout.getSeconds(), 
TimeUnit.SECONDS);

Review Comment:
   In this case, `startAsync` is not really working as expected when using the 
FSConfigurationManager. The actual work being done in cluster is done via the 
`FSConfigurationManager` when that class takes that config and produces a 
source out of the `.conf` file.
   
   The `awaitHealthy` call here waits indefinitely and suspends this current 
thread in the current implementation. It does not impede our ability to 
fail-fast because often just hangs if there's an issue. If anything, we can 
fail faster because a configurable timeout allows us to unblock this thread and 
trigger the `shutdown` when the `Workflow` finishes (successfully or 
unsuccessfully)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to