[
https://issues.apache.org/jira/browse/GOBBLIN-2014?focusedWorklogId=909276&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909276
]
ASF GitHub Bot logged work on GOBBLIN-2014:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/24 20:52
Start Date: 11/Mar/24 20:52
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#issuecomment-1989424373
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3894?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `0%` with `22 lines` in your changes are
missing coverage. Please review.
> Project coverage is 41.33%. Comparing base
[(`02eca4f`)](https://app.codecov.io/gh/apache/gobblin/commit/02eca4f8de577930b4ba88f138b3631102308524?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`46fe7c5`)](https://app.codecov.io/gh/apache/gobblin/pull/3894?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3894?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...mporal/ddm/launcher/ExecuteGobblinJobLauncher.java](https://app.codecov.io/gh/apache/gobblin/pull/3894?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vbGF1bmNoZXIvRXhlY3V0ZUdvYmJsaW5Kb2JMYXVuY2hlci5qYXZh)
| 0.00% | [22 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3894?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3894 +/- ##
============================================
- Coverage 46.53% 41.33% -5.20%
+ Complexity 11149 2197 -8952
============================================
Files 2231 475 -1756
Lines 87881 20146 -67735
Branches 9632 2333 -7299
============================================
- Hits 40893 8328 -32565
+ Misses 43288 10934 -32354
+ Partials 3700 884 -2816
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3894?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 909276)
Time Spent: 20m (was: 10m)
> Add metadata tags for events sent from Temporal to be parseable in GaaS
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2014
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2014
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Gobblin's Temporal workflow launches through `ExecuteGobblinJobLauncher`, but
> the eventSubmitter created in that class does not have the necessary metadata
> needed in order to send events to GaaS.
> We want to populate the additional tags to read from the job props that
> contain the information needed for these events to be readable from GaaS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
