[
https://issues.apache.org/jira/browse/GOBBLIN-2014?focusedWorklogId=909488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909488
]
ASF GitHub Bot logged work on GOBBLIN-2014:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/24 20:19
Start Date: 12/Mar/24 20:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1522061958
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/PriorJobStateWUProcessingSpec.java:
##########
@@ -78,42 +78,13 @@ public boolean isToDoJobLevelTiming() {
try {
FileSystem fs = Help.loadFileSystemForce(this);
JobState jobState = Help.loadJobStateUncached(this, fs);
- List<Tag<?>> tagsFromCurrentJob = this.getTags();
- String metricsSuffix = this.getMetricsSuffix();
- List<Tag<?>> tags = this.calcMergedTags(tagsFromCurrentJob,
metricsSuffix, jobState);
- return new EventSubmitterContext(tags, JobMetrics.NAMESPACE);
+ return new EventSubmitterContext.Builder()
+ .addTags(this.getTags())
+ .withGaaSJobProps(jobState.getProperties())
Review Comment:
is the invocation order critical here?
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ProcessWorkUnitsJobLauncher.java:
##########
@@ -85,7 +85,9 @@ public void submitJob(List<WorkUnit> workunits) {
URI nameNodeUri = new URI(PropertiesUtils.getRequiredProp(this.jobProps,
GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_NAME_NODE_URI));
// NOTE: `Path` is challenging for temporal to ser/de, but nonetheless
do pre-construct as `Path`, to pre-validate this prop string's contents
Path workUnitsDir = new
Path(PropertiesUtils.getRequiredProp(this.jobProps,
GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_WORK_UNITS_DIR));
- EventSubmitterContext eventSubmitterContext = new
EventSubmitterContext(this.eventSubmitter);
+ EventSubmitterContext eventSubmitterContext = new
EventSubmitterContext.Builder()
+ .withEventSubmitter(eventSubmitter)
+ .build();
Review Comment:
actually, I did just suggest that you add a `Builder` ctor, but thinking
more, why force the use of this builder, when the old `EventSubmitterContext`
continues to serve this base case just fine?
Issue Time Tracking
-------------------
Worklog Id: (was: 909488)
Time Spent: 1h 50m (was: 1h 40m)
> Add metadata tags for events sent from Temporal to be parseable in GaaS
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2014
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2014
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Gobblin's Temporal workflow launches through `ExecuteGobblinJobLauncher`, but
> the eventSubmitter created in that class does not have the necessary metadata
> needed in order to send events to GaaS.
> We want to populate the additional tags to read from the job props that
> contain the information needed for these events to be readable from GaaS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
