[ 
https://issues.apache.org/jira/browse/GOBBLIN-2014?focusedWorklogId=909294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909294
 ]

ASF GitHub Bot logged work on GOBBLIN-2014:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Mar/24 22:18
            Start Date: 11/Mar/24 22:18
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1520485487


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaAvroJobStatusMonitor.java:
##########
@@ -154,6 +154,7 @@ public org.apache.gobblin.configuration.State 
parseJobStatus(GobblinTrackingEven
         break;
       case TimingEvent.FlowTimings.FLOW_SUCCEEDED:
       case TimingEvent.LauncherTimings.JOB_SUCCEEDED:
+      case TimingEvent.LauncherTimings.JOB_COMPLETE:

Review Comment:
   is the alt. to adding this in KafkaAvroJSM to instead have 
`ExecuteGobblinWorkflowImpl` emit `JOB_SUCCEEDED`?  if that's what 
gobblin-on-MR emitted, I'd prefer to fix the new producer rather than change 
the long-time consumer.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 909294)
    Time Spent: 40m  (was: 0.5h)

> Add metadata tags for events sent from Temporal to be parseable in GaaS
> -----------------------------------------------------------------------
>
>                 Key: GOBBLIN-2014
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2014
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Gobblin's Temporal workflow launches through `ExecuteGobblinJobLauncher`, but 
> the eventSubmitter created in that class does not have the necessary metadata 
> needed in order to send events to GaaS.
> We want to populate the additional tags to read from the job props that 
> contain the information needed for these events to be readable from GaaS.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to