[
https://issues.apache.org/jira/browse/GOBBLIN-2014?focusedWorklogId=909489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909489
]
ASF GitHub Bot logged work on GOBBLIN-2014:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/24 20:19
Start Date: 12/Mar/24 20:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1522041593
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/EventSubmitterContext.java:
##########
@@ -119,6 +70,70 @@ private static Class resolveClass(String
canonicalClassName) {
} catch (ClassNotFoundException e) {
throw new RuntimeException(e);
}
+ }
+
+ public static class Builder {
+ private List<Tag<?>> tags = new ArrayList<>();
+ private String namespace;
Review Comment:
up to you, but I would simplify point of use w/ `@AllArgsConstructor`
Issue Time Tracking
-------------------
Worklog Id: (was: 909489)
Time Spent: 2h (was: 1h 50m)
> Add metadata tags for events sent from Temporal to be parseable in GaaS
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2014
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2014
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Gobblin's Temporal workflow launches through `ExecuteGobblinJobLauncher`, but
> the eventSubmitter created in that class does not have the necessary metadata
> needed in order to send events to GaaS.
> We want to populate the additional tags to read from the job props that
> contain the information needed for these events to be readable from GaaS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)