[
https://issues.apache.org/jira/browse/GOBBLIN-2073?focusedWorklogId=921443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921443
]
ASF GitHub Bot logged work on GOBBLIN-2073:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/24 21:24
Start Date: 30/May/24 21:24
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1621444363
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MysqlMultiActiveLeaseArbiterTest.java:
##########
@@ -264,12 +269,19 @@ public void
testConditionallyAcquireLeaseIfFinishedLeasingStatement()
*/
@Test (dependsOnMethods =
"testConditionallyAcquireLeaseIfFinishedLeasingStatement")
public void testOlderReminderEventAcquireLease() throws IOException {
+ // Use current time as flowName to create unique event
+ DagActionStore.DagAction newLaunchAction = new
DagActionStore.DagAction(flowGroup,
+ String.valueOf(System.currentTimeMillis()), flowExecutionId, jobName,
DagActionStore.DagActionType.LAUNCH);
Review Comment:
I want to repeatedly obtain a unique string to use for flow name and don't
want these variables accidentally reused between tests. I could also use `UUID
uuid = UUID.randomUUID(); String name = uuid.toString().substring(0, 5);` but
they will also be unknown. The point of the tests are that we want to know
whether it's a unique dagAction or one seen before not really what the value of
the name is. Are you worried that the name may not be unique this way?
Issue Time Tracking
-------------------
Worklog Id: (was: 921443)
Time Spent: 2h (was: 1h 50m)
> Add eventTime and reminder fields to DagAction POJO
> ---------------------------------------------------
>
> Key: GOBBLIN-2073
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2073
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> An event timestamp and reminder flag are used in conjunction with DagActions
> for lease arbitration and for reminder dagActions. It makes sense to include
> these fields in the DagAction object itself to easily transfer the
> information from one location to another. In particular for reminder events
> used to check back in on incomplete dagAction leases, these two fields are
> utilized and it's easiest to keep track of them when it's maintained within
> the consensusDagAction returned in a LeaseAttemptStatus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
