[
https://issues.apache.org/jira/browse/GOBBLIN-2073?focusedWorklogId=923567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923567
]
ASF GitHub Bot logged work on GOBBLIN-2073:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/24 19:38
Start Date: 14/Jun/24 19:38
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1640264488
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MultiActiveLeaseArbiter.java:
##########
@@ -48,19 +48,18 @@ public interface MultiActiveLeaseArbiter {
* acquisition timestamp of the entry for that dag action event (it could
have pre-existed in the table or been newly
* added by the previous write). Based on the transaction results, it will
return {@link LeaseAttemptStatus} to
* determine the next action.
- * @param dagAction uniquely identifies the flow and the present action upon
it
- * @param eventTimeMillis is the time this dag action was triggered
- * @param isReminderEvent true if the dag action event we're checking on is
a reminder event
+ *
+ * @param leaseObject uniquely identifies the flow, the
present action upon it, the time the action
+ * was triggered, and if the dag action
event we're checking on is a reminder event
* @param adoptConsensusFlowExecutionId if true then replaces the dagAction
flowExecutionId returned in
* LeaseAttemptStatuses with the
consensus eventTime, accessed via
* {@link
LeaseAttemptStatus#getConsensusDagAction()}
- *
* @return {@link LeaseAttemptStatus}, containing, when
`adoptConsensusFlowExecutionId`, a universally-agreed-upon
* {@link DagActionStore.DagAction} with a possibly updated ("laundered")
flow execution id that MUST be used thereafter
* @throws IOException
*/
- LeaseAttemptStatus tryAcquireLease(DagActionStore.DagAction dagAction, long
eventTimeMillis, boolean isReminderEvent,
- boolean adoptConsensusFlowExecutionId)
+ // todo: change to use leaseObject here that contains dagAction with
reminder, eventTime
Review Comment:
todo is complete, right?
Issue Time Tracking
-------------------
Worklog Id: (was: 923567)
Time Spent: 3h 20m (was: 3h 10m)
> Add eventTime and reminder fields to DagAction POJO
> ---------------------------------------------------
>
> Key: GOBBLIN-2073
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2073
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> An event timestamp and reminder flag are used in conjunction with DagActions
> for lease arbitration and for reminder dagActions. It makes sense to include
> these fields in the DagAction object itself to easily transfer the
> information from one location to another. In particular for reminder events
> used to check back in on incomplete dagAction leases, these two fields are
> utilized and it's easiest to keep track of them when it's maintained within
> the consensusDagAction returned in a LeaseAttemptStatus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
